feat: support using delimiter in scope-enum#1
Closed
colinaaa wants to merge 2 commits intoupsteam-masterfrom
Closed
feat: support using delimiter in scope-enum#1colinaaa wants to merge 2 commits intoupsteam-masterfrom
scope-enum#1colinaaa wants to merge 2 commits intoupsteam-masterfrom
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, if the scope in message has delimiters(
/,,or\), it is considered as multiple scopes and is tested separately.I add extra checks to see if the scope matches the enum directly to allow
'scope-enum'to have delimiter.Motivation and Context
Scope should be able to have delimiter like
/. And tests should pass when'scope-enum'is configured to have delimiter.Usage examples
How Has This Been Tested?
multipleSlashtest case is added.foo/bartoscope-enumwould work.Types of changes
Checklist: