[pull] master from rust-lang:master#7
Merged
Conversation
report entries This captures the current behavior of the report.
# What Does This PR Try to Resolve? Fixes #17212 # How to Test and Review This PR? The first commit adds tests pinning the current behavior. The second commit fixes the underlying issues and updates the tests as needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by cubic
Fix timing reports to only include units the job queue actually ran and to handle no-work sessions correctly. Removes zero-duration rows and clarifies behavior between
--timingsandcargo report timings(fixes rust-lang#17212).Bug Fixes
--timings: always writes a report; shows an empty dataset (const UNIT_DATA = [];) when nothing ran.cargo report timings: errors on logs with no units with “no timing data found in log”.error_if_no_unitstoprepare_contextand updated call sites to set it appropriately.Tests
cargo report timingserrors;--timingsstill generates an empty report.Written for commit e09f57a. Summary will update on new commits.