Merged
Conversation
This validator is useful when a field is not required but if it exists it cannot be empty. This is needed since type validators ignore empty values as valid, but an empty string is not a date!
Contributor
|
@elpete can you please send me a PR for the docs on this please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This validator is useful when a field is not required but if it exists it cannot be empty.
This is needed since type validators ignore empty values as valid, but an empty string is not a date!
Here's why I added it:
These validation constraints are typical in our search endpoint — no keys are needed, but if it exists it needs to be a date. Unfortunately,
requiredcounts empty strings as valid andtypeignores empty strings as "not required". Then my application is dealing with an empty string trying to use it as a date.With this new constraint, I would add it in like so:
It still isn't required, but the value must be a non-empty value and it must be parseable as a date.