cbsecurity_logs is hard coded instead of using module setting#47
Merged
lmajano merged 1 commit intocoldbox-modules:developmentfrom Sep 12, 2023
Merged
Conversation
cbsecurity_logs is hard coded instead of using module setting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The table name is a module setting which is referenced in some but not all places. Replaced hard coded
cbsecurity_logsreferences with existinggetTable()call to be consistent throughout so that the module setting is used when provided.Issue raised as:
https://ortussolutions.atlassian.net/browse/BOX-141