Fix getKey() return typing to allow composite keys#21
Merged
lmajano merged 1 commit intodevelopmentfrom Sep 1, 2017
Merged
Conversation
If a composite primary key is in place, `getKey()` will return an array. Changing the typing to account for this.
Contributor
|
Seems the build fails? |
Contributor
Author
|
Well that's odd. I wouldn't think that test would have anything to do with this PR ( https://github.com/coldbox-modules/cbox-cborm/blob/jclausen-key-patch/tests/specs/ActiveEntityTest.cfc#L188 ). Seems like it's ACF 2016-specific. I'll take a look at it and update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a composite primary key is in place,
getKey()in the BaseORMService will return an array. Changing the typing to account for this.