fix: handle objective constant with gurobi #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tuliotoffolo
approved these changes
Jan 16, 2022
tuliotoffolo
requested changes
Jan 16, 2022
Contributor
tuliotoffolo
left a comment
tuliotoffolo
left a comment
There was a problem hiding this comment.
Thanks for the fix.
Would you please do obj_expr.const = self.get_objective_const() instead? The summation would result in the creation of a new LinExpr, which is unnecessary here.
|
Hello, are there any updates on this? |
Collaborator
|
@gdragotto I will do a short review in the next few days, but I think this is ready so far. @peterlietz Would you squash the commits and give it a speaking name? Otherwise, I would do it. |
peterlietz
force-pushed
the
gurobi_obj_const
branch
from
627cd59 to
b646385
Compare
Contributor
Author
|
Hi @sebheger, I squashed the changes. Hope everything is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added two unit tests that currently fail for gurobi along with the proposed fix.