Remove obsolete typing.io import#922
Closed
srittau wants to merge 4 commits intocognitedata:masterfrom
srittau:patch-1
Closed
Remove obsolete typing.io import#922srittau wants to merge 4 commits intocognitedata:masterfrom srittau:patch-1
srittau wants to merge 4 commits intocognitedata:masterfrom
srittau:patch-1
Conversation
`typing.io` has been deprecated since Python 3.8 and will be removed in Python 3.12. `TextIO` and `BinaryIO` are available from the main `typing` namespace, though, so the existing star import should be sufficient.
Contributor
|
Thanks! This has been addressed in a different PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
typing.iohas been deprecated since Python 3.8 and will be removed in Python 3.12.TextIOandBinaryIOare available from the maintypingnamespace, though, so the existing star import should be sufficient.Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
Does this require a changelog entry?