Add class attribute to change the graph direction#90
Add class attribute to change the graph direction#90codingjoe merged 4 commits intocodingjoe:mainfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 97.86% 98.01% +0.14%
==========================================
Files 17 17
Lines 703 705 +2
==========================================
+ Hits 688 691 +3
+ Misses 15 14 -1
☔ View full report in Codecov by Sentry. |
codingjoe
left a comment
codingjoe
left a comment
There was a problem hiding this comment.
Hi @peterbaumert,
Thank you for your contribution. I always love, when people come up with excellent improvements to my packages.
Regarding your suggestion, I believe being able to adapt the direction is a splendid idea. However, I am hesitant to add settings for everything. I believe in most cases, inheritance is the more Pythonic approach to adapting behavior changes.
Might I suggest making direction a class attribute? As an added bonus, this would allow you to alter directions per individual workflow.
Best!
Joe
|
Maybe also go ahead and add a small test to prevent any regression. |
Yeah that would have made sense now that you mention it :D Will look into it those days. The test part will be something that I need to learn about first. Never did it before 🙄 |
|
Hi @codingjoe I added a test, but I am not 100% sure if that is sufficient since it's my first time with tests :D Would be great if you could have a look |
codingjoe
left a comment
codingjoe
left a comment
There was a problem hiding this comment.
Wonderful, took the liberty and added a commit. I added documentation and a small improvement to your test. Thanks again, for the contribution!
codingjoe
force-pushed
the
graph_direction
branch
from
fdb39ab to
f3051ce
Compare
codingjoe
force-pushed
the
graph_direction
branch
from
f3051ce to
7a6de12
Compare
codingjoe
changed the title
2 participants
Solve #33