Narrow DB locks from table to specific rows#148
Conversation
Prometheus client became optional in dramatiq v2: https://github.com/Bogdanp/dramatiq/releases/tag/v2.0.0 I think we don't need to cover all our dependencies's subdependencies, so it is fine to drop it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 17 17
Lines 805 805
=======================================
Hits 787 787
Misses 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes the Prometheus middleware from the dramatiq broker configuration in the test application settings, aligning with dramatiq v2 where the Prometheus client became optional.
- Removes
"dramatiq.middleware.Prometheus"from the MIDDLEWARE list in DRAMATIQ_BROKER configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@codingjoe I couldn't figure this out from the first look. Broker is now raising exceptions immediately when tasks retry. |
|
@amureki dramatic tests fail though 🙈 |
yeah, as I mentioned above, I am not sure how could we proceed here - need to evaluate this more. I'd need to invest more time into it, but also if you have suggestions, I'd be happy to hear! |
|
@amureki any updates? I am not as familiar with the changes in dramatiq as you are, but let me know if you need a hand. |
|
@codingjoe
|
codingjoe
changed the title
Prometheus client became optional in dramatiq v2:
https://github.com/Bogdanp/dramatiq/releases/tag/v2.0.0
I think we don't need to cover all our dependencies's subdependencies, so it is fine to drop it.