Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the PyPI publishing workflow by switching from password-based authentication to OIDC (OpenID Connect) trusted publishing, which is a more secure and maintainable approach.
Key changes:
- Split the workflow into two jobs:
release-build(builds artifacts) andpypi-publish(publishes to PyPI) - Replaced manual
twine uploadwith the officialpypa/gh-action-pypi-publishaction - Added OIDC permissions (
id-token: write) for secure authentication
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| env: | ||
| TWINE_USERNAME: __token__ | ||
| TWINE_PASSWORD: ${{ secrets.TWINE_PASSWORD }} | ||
| - uses: actions/upload-artifact@v5 |
There was a problem hiding this comment.
Mismatched artifact action versions. The workflow uses actions/upload-artifact@v5 for uploading but actions/download-artifact@v6 for downloading. These should use matching major versions to ensure compatibility. Either use @v5 for both or @v6 for both.
| - uses: actions/upload-artifact@v5 | |
| - uses: actions/upload-artifact@v6 |
| @@ -2,17 +2,32 @@ name: Release | |||
| on: | |||
| release: | |||
| types: [published] | |||
There was a problem hiding this comment.
[nitpick] The addition of workflow_dispatch trigger enables manual workflow execution, but there's no documentation or comment explaining why this trigger was added or when it should be used. Consider adding a comment to clarify the intended use case for manual triggering.
| types: [published] | |
| types: [published] | |
| # Allows maintainers to manually trigger the release workflow if an automated release event fails or a release needs to be published outside the normal process. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 97.63% 97.76% +0.12%
==========================================
Files 17 17
Lines 805 805
==========================================
+ Hits 786 787 +1
+ Misses 19 18 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.