Conversation
codingjoe
left a comment
codingjoe
left a comment
There was a problem hiding this comment.
Hi there 👋,
Thanks for reaching out and your contribution. I left you a review to help you improve your patch. Next time, maybe consider opening a discussion before jumping right into code, to keep review cycles shorter.
Best
Joe
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This allows to start new workflows from views that don't inherit from BaseCreateView. This is useful if you e.g. want to start a view from json input and don't need forms.
fvollmer
force-pushed
the
StartWorkflowMixin
branch
from
b3336ed to
a6f456d
Compare
codingjoe
force-pushed
the
StartWorkflowMixin
branch
from
7f8855a to
d047d86
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
=======================================
Coverage 97.87% 97.88%
=======================================
Files 17 17
Lines 705 708 +3
=======================================
+ Hits 690 693 +3
Misses 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
codingjoe
left a comment
codingjoe
left a comment
There was a problem hiding this comment.
I took the liberty and wrapped this up for you 😃
| from .conf import settings | ||
| from .typing import HUMAN, MACHINE | ||
| from .utils import NoDashDiGraph | ||
| from .views import StartViewMixin |
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
|
Great to see a new release. I came to thre PR to out what it was about and thought I'd mention a releases page would be welcome on the website, along with mention of the new mixin. Cheers and thanks for contributing and maintaining! |
4 participants
This allows to start new workflows from views that don't inherit from BaseCreateView. This is useful if you e.g. want to start a view from json input and don't need forms.