Conversation
Closed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
==========================================
- Coverage 97.72% 96.95% -0.78%
==========================================
Files 8 8
Lines 264 230 -34
==========================================
- Hits 258 223 -35
- Misses 6 7 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the v6 web component rewrite, rolling back from a custom <s3-file> web component implementation to the traditional file input approach with JavaScript event handlers, while preserving updates to the Selenium test suite and package configuration.
Key Changes:
- Reverted from web component (
<s3-file>) to traditional file input with class-based targeting - Replaced modern fetch-based upload logic with XMLHttpRequest for progress tracking
- Removed web component-related Python classes (Asset, ESM, InputToS3FileRewriter)
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/testapp/templates/form.html | Reverted template to use standard file inputs; added progress bar example and event handling script |
| tests/test_forms.py | Removed web component unit tests; updated Selenium tests to target file inputs by name instead of type; added slugify for test file naming |
| tests/conftest.py | Added slugify to test fixture filenames for consistency |
| tests/tests/s3file.test.js | Removed all JavaScript unit tests for the web component implementation |
| s3file/static/s3file/js/s3file.js | Reverted from web component class to traditional IIFE-based implementation with XHR |
| s3file/forms.py | Removed InputToS3FileRewriter, Asset, and ESM classes; restored class-based widget rendering |
| README.md | Added progress bar documentation and usage examples |
| .pre-commit-config.yaml | Added esupgrade hook for JavaScript code modernization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
codingjoe
force-pushed
the
issues/363/revert
branch
2 times, most recently
from
94b1bc6 to
a49b3c0
Compare
Back to the roots, I carefully reverted the web component changes while keeping the updates to the senlenium suite and the package. Reverts 2706cb3
codingjoe
force-pushed
the
issues/363/revert
branch
from
a49b3c0 to
e335529
Compare
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back to the roots, I carefully reverted the web component changes
while keeping the updates to the senlenium suite and the package.
Reverts 2706cb3