Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Selenium test suite to run tests across multiple browsers (Chrome, Firefox, and Safari) instead of just Chrome. It also updates file path handling in multi-file upload tests.
Key changes:
- Parameterized the driver fixture to test against Chrome, Safari, and Firefox
- Changed from Chrome-specific options to dynamic browser options instantiation
- Modified file path separator in multi-file upload test from
" \n "to"\n"
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/conftest.py | Converts Chrome-only driver fixture to parameterized multi-browser fixture supporting Chrome, Safari, and Firefox |
| tests/test_forms.py | Updates file path separator for multi-file upload from " \n " to "\n" for better cross-browser compatibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
codingjoe
force-pushed
the
selenium
branch
2 times, most recently
from
b5a0aeb to
1eaf582
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.