Use perf timer to improve RTP packet sending frequency#51
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
+ Coverage 94.58% 94.59% +0.01%
==========================================
Files 24 24
Lines 1716 1721 +5
==========================================
+ Hits 1623 1628 +5
Misses 93 93 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adjusts outbound RTP audio pacing in AudioCall by switching from fixed sleeps to a perf_counter()-based interval calculation to better maintain the intended packet cadence.
Changes:
- Add
timeimport and alast_packet_timefield onAudioCallfor pacing state. - Change
send_audio()to compute sleep time based on elapsed time since the last packet send, rather than always sleeping a fixed duration.
You can also share your feedback on Copilot code review. Take the survey.
voip/audio.py
Outdated
Comment on lines
+214
to
+218
| for payload in self.codec.packetize(audio): | ||
| await asyncio.sleep( | ||
| self.rpt_packet_duration.total_seconds() | ||
| - (time.perf_counter() - self.last_packet_time) | ||
| ) |
voip/audio.py
Outdated
Comment on lines
+215
to
+218
| await asyncio.sleep( | ||
| self.rpt_packet_duration.total_seconds() | ||
| - (time.perf_counter() - self.last_packet_time) | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.