Remove duplicated RTPProtocol tests#11
Merged
codingjoe merged 2 commits intotranscribe-callfrom Mar 9, 2026
Merged
Conversation
Co-authored-by: codingjoe <[email protected]>
Copilot
AI
changed the title
[WIP] Work in progress on call transcription feedback
Remove duplicated RTPProtocol tests
Mar 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## transcribe-call #11 +/- ##
================================================
Coverage 95.85% 95.85%
================================================
Files 11 11
Lines 531 531
================================================
Hits 509 509
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Removes duplicated RTPProtocol unit tests in tests/test_rtp.py, keeping the more maintainable/consistent versions that use the make_rtp_packet() helper.
Changes:
- Deleted the redundant
TestRTPProtocoltest methods that used hardcoded raw byte literals. - Kept the existing “canonical”
TestRTPProtocoltests that cover the same behaviors usingmake_rtp_packet().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestRTPProtocolintests/test_rtp.pycontained two sets of effectively identical tests forrtp_header_sizeanddatagram_receivedbehavior, differing only in fixture style and naming.Changes
RTPProtocoltests that used hardcoded raw byte literals:test_rtp_header_size__is_class_attrtest_datagram_received__forwards_audiotest_datagram_received__skips_short_packettest_datagram_received__skips_exact_header_sizemake_rtp_packet()factory helper, which produces more readable and maintainable assertions.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.