Merged
Conversation
Previously, we would pass ids to the creation handler. However, this does not pass validations whenever the association is non-optional (i.e. belongs_to). With these changes, we pass the actual Rails objects instead of just the ids, which does pass the validations and sets it properly.
Taeir
changed the title
Settings are now properly loaded from the database.yml config file, rather than only taking some of those settings.
Taeir
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added logic for seeding to translate all _id mappings in the seeds to their actual rails objects to please rails and its validations.
Additionally fixes redis by reverting it to version 4 and updating the settings. Version 5 currently has a bug which causes issues for the development setup, and in some cases also the production setup. See redis/redis-rb#1157