Conversation
…a markdown helper
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trichoplax
left a comment
trichoplax
left a comment
There was a problem hiding this comment.
What I understand looks good to me, but I don't have an understanding of TypeScript yet so I'll leave it to someone else to approve those changes.
So this is just to confirm that I've tested that the code golf assets still work and that pressing Enter in the Edit Comment field while editing a post no longer adds an empty Markdown link to the Body field. Pressing Enter in the Edit Comment field does now save the edit, which I assume is intentional (seems reasonable behaviour to me).
…he sidebar without the notice
…ven if there's no notice
cellio
left a comment
cellio
left a comment
There was a problem hiding this comment.
I've tested the Sefaria linker with the latest changes and all looks good now. I assume that other reviewers did a code review and tested Code Golf.
4 participants
closes #1058
The PR also:
QPixel.MDcommon API global object;judasim.jscommunity asset without the sidebar notice setting filled in;Since the PR touches upon community assets, DO NOT MERGE until both @trichoplax and @cellio approve (that is, unless you check that those assets work fine with changes yourself).