Account for text fragments when autoexpanding post history items#1928
Account for text fragments when autoexpanding post history items#1928
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Oaphi
changed the title
trichoplax
left a comment
trichoplax
left a comment
There was a problem hiding this comment.
Great to see more jQuery being retired.
The functionality of each previous jQuery line is replicated without the vulnerability to text fragment directives in the URL, so this looks complete to me, and I've approved.
The only comments I've made are a matter of personal preference where I can't guess what will be easier to read for different people, so I've just listed some thoughts. I'm fine with this being merged as is though.
cellio
left a comment
cellio
left a comment
There was a problem hiding this comment.
I tested on my dev server with the URL http://localhost:3000/posts/46/history#2:~: and it went to the correct history entry. I don't know what:~: is supposed to do (I got that from the bug report), but it doesn't do something obviously bad now. If @trichoplax (who understands the problem more than I do) is happy, I'm happy.
As a quick FYI, |
|
Confirmed on dev server: https://a.dev.codidact.org/posts/725/history#2:~: |
4 participants
closes #1925