expand who can rename threads, with public log#1873
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
I believe the latest set of commits is currently missing (we've definitely discussed schema changes and not hardcoding the renamer user's username in the comment's message) - I don't recall if those commits were supposed to be added later, RC'ing just so as we don't merge without them by accident.
…leted users as usual)
I've fixed the literal name in favor of a link as we mentioned. If the renaming user is deleted, this shows "deleted user" as expected, without leaking the original name. Arguably the schema changes could be done separately; we already had renaming and already failed to record the user and time. |
3 participants
Currently, only curators can rename comment threads. We've had many requests over the years from authors who didn't like the auto-generated title or wanted to fix a typo, but renames were also silent, so we wanted to restrict this to mitigate against abuse. (After all, a silently-renamed thread puts that name in the mouth of the person who created that thread.)
This change adds attribution for renamed threads, like this:
The comment is owned by System, not the renamer, so that regular users can't delete the comments. These comments are created directly and do not ping followers (just as we do not notify followers for other state changes like lock and archive).
Non-curator users can only rename threads they've participated in, like this:
Fixes #714.