Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Nice! I see the arrows in "related" and "hot", which I assume are collapse/expand controls, but when I click them nothing happens. 
|
|
Works On My Machine™️... Restarted the Rails server? Any errors in the console? |
|
Huh. Didn't notice any errors before (though they'd since aged out of the history if they were there), but after restarting the server it works fine. I'll try to remember to try that in future testing. |
|
Unless we disable the Sprockets's asset cache for the development env, yes, IIRC, every time an asset is added or removed, Rails needs to be restarted. Just changing one is fine, though, I believe |
|
LGTM from a functional perspective. I have not done a code review (and am not qualified for JavaScript). |
No need to change our setup. The change needed was in this user's memory. :-) |
| @@ -0,0 +1,14 @@ | |||
| .widget--body { | |||
| transition: all 0.2s ease; | |||
There was a problem hiding this comment.
Suggestion for consistency (since we use SCSS):
.widget--body {
transition: all 0.2s ease;
&.hiding {
scale: 0;
height: 0;
margin: 0;
padding: 0;
}
&.hidden {
display: none;
}
}3 participants
Closes #1348.
Adds a related posts widget to the sidebar, between the now-split "featured" and "hot posts" widgets.
Also makes related and hot posts widgets collapsible, controlled by user preference.