Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Ready for review, but let's hold off this one until #1647 is merged. |
|
We don't allow admins or mods to self-delete (good), but the check is at the end. Instead of sending the user through the sudo path (password, then type user name, then get the error), can we check when the person clicks the button? Other than that, looks great! I tested all the special statuses (local/global mod/admin), and confirmed that staff alone doesn't block deletion. The deletions show up in the audit log as expected, and that email address/password no longer works to sign in. A self-deleted user can sign up again with the same email address and gets a new account. |
|
Good catch - I meant to just not show the button for special users, perhaps with a caption instead, but forgot to add that. |
|
Grayed out with an explanation would be consistent with other buttons that are selectively not available. But any way you want to handle it (at the beginning) is fine. |
cellio
left a comment
There was a problem hiding this comment.
LGTM. Defer merge until after 1647 merges.
Suggestions for PR #1668
Adds self-serve account deletion.
Closes #925.