Skip to content

Add summary emails#1662

Merged
Oaphi merged 12 commits intodevelopfrom
art/summary-emails
Jul 1, 2025
Merged

Add summary emails#1662
Oaphi merged 12 commits intodevelopfrom
art/summary-emails

Conversation

@ArtOfCode-
Copy link
Member

@ArtOfCode- ArtOfCode- commented Jun 27, 2025

Adds content summary emails sent to staff. Helps in raising our email volume to avoid AWS issues...

@ArtOfCode- ArtOfCode- requested review from a team and Oaphi June 27, 2025 15:33
@codecov
Copy link

codecov bot commented Jun 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.50%. Comparing base (93b9fd9) to head (bb132a5).
Report is 13 commits behind head on develop.

Additional details and impacted files
Components Coverage Δ
controllers 61.81% <ø> (ø)
helpers 69.29% <ø> (+0.11%) ⬆️
jobs 48.57% <100.00%> (+20.57%) ⬆️
models 81.92% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Oaphi
Oaphi requested changes Jul 1, 2025
View reviewed changes
Copy link
Member

@Oaphi Oaphi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions incoming shortly - it also seems it's the first time we've ever tried to pass ActiveRecord::Relation as a parameter to .with( - which I believe is not a supported type? Seems to be corroborated by the "Unsupported argument type: ActiveRecord::Relation" error when trying to implement tests.

#1667

@Oaphi
Copy link
Member

Oaphi commented Jul 1, 2025 •
edited
Loading

tsck, seems like mail delivery test might need better isolation (or maybe not, the pipeline only complains about the recipient's email), CircleCI didn't like the merged version at all. Initially. Must be flaky. Yup, definitely flaky.

@Oaphi Oaphi self-requested a review July 1, 2025 19:22
Oaphi
Oaphi approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@Oaphi Oaphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oaphi Oaphi merged commit 7a2a1f6 into develop Jul 1, 2025
10 checks passed
@Oaphi Oaphi deleted the art/summary-emails branch July 1, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Oaphi Oaphi Oaphi approved these changes

Assignees

No one assigned

Labels

priority: high

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ArtOfCode- @Oaphi