Skip to content

show who reviewed an edit in the 'decided' list#1634

Merged
Oaphi merged 2 commits intodevelopfrom
cellio/edit-show-reviewer
May 24, 2025
Merged

show who reviewed an edit in the 'decided' list#1634
Oaphi merged 2 commits intodevelopfrom
cellio/edit-show-reviewer

Conversation

@cellio
Copy link
Member

@cellio cellio commented May 20, 2025

Small change suggested in chat recently: in the list of handled suggested edits, show who handled it. The information is shown on the individual item if you click through, but this makes it a little easier to find a specific review.

screenshot: adds "handled by (name)" after the editor name and time

@cellio cellio requested a review from a team May 20, 2025 01:58
@Oaphi
Copy link
Member

Oaphi commented May 20, 2025

Not a blocker, but I'd move the info to the next line - the line gets a bit unreadable given a sufficiently long username - like this (on a tangent, I also think that the line should say "decided by", not "reviewed by" to be future-proof):

image

@cellio
Copy link
Member Author

cellio commented May 20, 2025

Not a blocker, but I'd move the info to the next line - the line gets a bit unreadable given a sufficiently long username - like this (on a tangent, I also think that the line should say "decided by", not "reviewed by" to be future-proof):

Good points, and if we move to the next line, including when it was reviewed should work for most usernames (and not be horrible for long ones).

@cellio
Copy link
Member Author

cellio commented May 20, 2025

Revised screenshot:

Decided by (name), (time) - on new line

@Oaphi
Copy link
Member

Oaphi commented May 24, 2025

LGTM

@Oaphi Oaphi merged commit e66ec55 into develop May 24, 2025
8 checks passed
@Oaphi Oaphi deleted the cellio/edit-show-reviewer branch May 24, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants