Move bulleted/ordered list and tables editor buttons to the first level#1619
Move bulleted/ordered list and tables editor buttons to the first level#1619
Conversation
|
I'm happy to defer to this PR and close mine. Would you be willing to expand the tooltip here to reflect what's still in there? In particular, while lines and headings are kind of uninteresting, tables should probably be more findable than they are. |
cellio
left a comment
cellio
left a comment
There was a problem hiding this comment.
LGTM other than the tooltip question.
@cellio what do you think about moving the table button to the first level too (I think it's best suited with the other "insert" buttons)? This is common practice to do so as well |
Sounds good to me, I'll merge your PR into mine then (after the CI pipeline finishes running that is) so as we get the best of both worlds. |
expanded tooltip for 'tools' button in editor
Works for me. I agree with promoting tables, at which point we're down to two tools right now. You'll need to adjust the wording on the tooltip. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@cellio agreed then, will do shortly - and we can also partially address another request that's just came in: meta:293940 |
Oaphi
changed the title
| attribs.merge! href: 'javascript:void(0)', | ||
| class: "#{attribs[:class] || ''} button is-muted is-outlined js-markdown-tool", | ||
| data_action: action, | ||
| draggable: false, |
There was a problem hiding this comment.
Forgot to mention it, but this change solves a minor issue of being able to drag & drop markdown buttons themselves into the editor (resulting in javascript:void(0) being inserted)
3 participants
Re: meta:293936 (doesn't close it, but related) and meta:293940 (partially addresses it)
Unfortunately, it competes with #1618 and will make it obsolete if merged.(merged in as per discussion)Rationale
It's very unusual for editor tools to not show list management buttons at first level, so I think we should not reinvent the wheel. Examples:
GitHub editor tools:
Stack Overflow editor tools:
Well-known CKEditor:
And countless others.
Changes
The change makes the tools panel look like this for a sufficiently wide viewport (note that list and table insertion buttons are no longer wrapped under the "tools" modal):
And like this for a narrow one (we should improve button positioning on narrow viewports in general, but that's outside the scope of the PR):
