user search should match any substring, not just initial substring#1606
Merged
user search should match any substring, not just initial substring#1606
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cellio
force-pushed
the
cellio/1474-user-search-substring
branch
from
bf05fe2 to
54c968e
Compare
ArtOfCode-
approved these changes
Apr 26, 2025
Oaphi
approved these changes
Apr 26, 2025
Member
Oaphi
left a comment
Oaphi
left a comment
There was a problem hiding this comment.
LGTM, just added a quick test to increase coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the
LIKEbehavior for user search align with that for tag search, so you can match a substring from the middle of the name and not just the initial substring. One-character fix.Fixes #1474.