pagination breaks when there are no tags#1469
Merged
Conversation
Oaphi
approved these changes
Dec 6, 2024
Member
There was a problem hiding this comment.
LGTM - there is a follow up discussion in Discord about further improvements, but it shouldn't preclude merging if we take too long. Not merging for now, but works as expected (up to you, @cellio, if you want to merge as is).
UPD: agreed on merging and tackling improvements separately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1353 . The problem is that we were checking nil but not a count of 0, and apparently tags pagination requires there actually be something there.
I do not fully understand the problem, because it appears that other places with pagination don't have these kinds of checks, but with this check in place, I can't break tag search in my local dev environment, so I propose to try it.