Merged
Conversation
ArtOfCode-
requested changes
Aug 12, 2020
Member
ArtOfCode-
left a comment
ArtOfCode-
left a comment
There was a problem hiding this comment.
Looking good so far!
I'd still like it if we could change code occurrences of TrustLevel/Privilege to Ability - aside from the database, which should just be a migration to rename them, the rest should just be a straight find & replace.
ArtOfCode-
requested changes
Nov 23, 2020
Member
|
@luap42 you requested a review from me, which I'm happy to do but I'm not sure what to focus on. I'm not going to be useful for general code review; is there UI text you want me to look at or a dev instance you want me to poke? |
ArtOfCode-
reviewed
Nov 24, 2020
ArtOfCode-
approved these changes
Nov 24, 2020
luap42
force-pushed
the
luap42/trust-levels
branch
from
e52c67e to
179b28c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is goin' to become quite huge, probably. (Edit: Yes.)
Adding this screenshot, so that I can add an explanation later :D
Ready for review.