Accessibility improvements#1078
Merged
ArtOfCode- merged 22 commits intocodidact:developfrom Jun 21, 2023
Merged
Conversation
The buttons that immediately take action are now correctly set to role button, such that screen readers / reader views understand them as such. The History and Edit button open new pages, so those are considered actual links.
Taeir
force-pushed
the
accessibility-improvements
branch
from
818efc5 to
9da4b6e
Compare
Now use a shared view with a parameter
This has some effects on mobile with regards to clearing the box, and can help with accessibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains multiple improvements for accessibility, screen readers, voice control and reader views. It may also improve SEO.
Note that this probably does not fix all accessibility issues, but it should at least help for the most-used pages. I expect a few quite small changes have a big impact, such as marking the sidebar as a sidebar.
Main changes:
Changes also in this PR:
Future recommendations:
aria-labeldescriptions to explain their meaning when the user cannot use visual clues.Fixes #404
Fixes #1068