Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saving an empty snippet does not show a warning on Pro #197

Closed
sheabunge opened this issue Dec 3, 2024 · 4 comments
Closed

Saving an empty snippet does not show a warning on Pro #197

sheabunge opened this issue Dec 3, 2024 · 4 comments
Assignees
@sheabunge
Labels
bug

Comments

@sheabunge
Copy link
Member

sheabunge commented Dec 3, 2024 •
edited
Loading

Current behavior

When saving a snippet using the small 'Save Changes' button above the code editor, if the snippet us missing its name or its code, a dialog box should appear for confirmation.

Expected behavior

The dialog box works correctly in Core, but not Pro.

Steps to reproduce

  1. Snippets > Add New
  2. leave fields unchanged
  3. click the small 'Save Changes' button above the code editor.
  4. see how snippet saves without triggering dialog box.

WordPress version

Version 6.7.1

Code Snippets version

3.6.6.1

Code Snippets license

Pro

Anything else?

Originally raised by Generosus here: https://wordpress.org/support/topic/two-findings-v3-6-6-1/
@sheabunge sheabunge added the bug label Dec 3, 2024
@sheabunge sheabunge self-assigned this Dec 3, 2024
@Generosus
Copy link

Thank you, Shea.

Friendly reminder: Please make sure all top buttons are fixed and tested. Meaning, the "Generated AI", "Save Changes", and "Activate" buttons. (details)

Cheers!

@sheabunge
Copy link
Member Author

sheabunge commented Dec 6, 2024 •
edited
Loading

Should be fixed in the latest development version! Looks like Pro was still using an older version of the save/activate button component, which didn't have the new dialog box logic integrated in.

We'll aim to release it as a patch in the coming week. Thanks again for bringing it to our attention!

@Generosus
Copy link

Generosus commented Dec 6, 2024 •
edited
Loading

Awesome, thank you! Do you know what the plugin build or revision level will be?

@sheabunge
Copy link
Member Author

The commit won't be in this repository, as it's in the Pro build, but the release version should be 3.6.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sheabunge sheabunge

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sheabunge @Generosus