Repository navigation
feat: Add support for shutdown_script - #79
Merged
Merged
Conversation
mafredri
approved these changes
Nov 24, 2022
mafredri
left a comment
mafredri
left a comment
Member
There was a problem hiding this comment.
Do you think we will need a shutdown_script_timeout as well? I think it'd be fine to wait indefinitely until shutdown script has completed, at least to start with. Most likely someone will want to debug something if the shutdown script has hung.
Member
Author
|
Yes, the idea is to come back quickly with basic feature. Then, I can extend it with extras like configurable execution timeout, retries, etc. |
johnstcn
approved these changes
Nov 25, 2022
Member
Author
|
Hey @kylecarbs, it seems that I'm not authorized to merge this PR. Could you please help with this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: coder/coder#4677
This PR introduces a new parameter - the shutdown script. The script is intended to be executed before the agent is stopped, before the networking is shut down.