🤖 fix: scroll to bottom on workspace switch using ResizeObserver #911
+48
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar-agent
force-pushed
the
workspace-scroll-bug-fix
branch
from
88250c5 to
297bab9
Compare
ammario
approved these changes
Dec 4, 2025
The previous double requestAnimationFrame approach failed when async content (Shiki highlighting, Mermaid diagrams, images) rendered after the scroll completed. Now we observe the inner message container for size changes during the auto-scroll window and re-scroll as needed. Changes: - Add ResizeObserver in useAutoScroll that triggers scroll on growth - Return innerRef callback ref from hook for attaching to content div - Wire up innerRef in AIView's message container _Generated with `mux`_
ammar-agent
force-pushed
the
workspace-scroll-bug-fix
branch
from
297bab9 to
6c25b1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes workspace switch not scrolling to bottom reliably.
Problem
Clicking a workspace didn't always scroll to the bottom because async content (Shiki highlighting, Mermaid diagrams, images) rendered after the double
requestAnimationFramescroll completed.Solution
Replace double RAF with a
ResizeObserveron the inner message container. When the container grows during the auto-scroll window, we re-scroll to bottom. The observer is managed via a callback ref that properly cleans up on unmount/re-attach.Generated with
mux