🤖 fix: guard activate handler against services race condition #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS, clicking the dock icon during startup (while splash is visible and services are loading) fires the activate event. The handler was calling createWindow() without checking if services were initialized, causing an assertion failure. Added services check to the condition - if services aren't ready, the handler does nothing and normal startup flow creates the window.
ammar-agent
added a commit
that referenced
this pull request
Dec 10, 2025
Adds MUX_E2E_DELAY_SERVICES_MS env var to artificially delay service loading, enabling tests that reproduce race conditions during startup. New test emits the macOS 'activate' event (dock click) while services are loading, verifying the app handles it gracefully without crashing. This would have caught the bug fixed in #1064.
ammar-agent
added a commit
that referenced
this pull request
Dec 10, 2025
Adds MUX_E2E_DELAY_SERVICES_MS env var to artificially delay service loading, enabling tests that reproduce race conditions during startup. New test emits the macOS 'activate' event (dock click) while services are loading, verifying the app handles it gracefully without crashing. This would have caught the bug fixed in #1064.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS, clicking the dock icon during startup (while splash is visible and services are loading) fires the activate event. The handler was calling
createWindow()without checking if services were initialized, causing an assertion failure:Fix: Added
servicescheck to the activate handler condition. If services aren't ready, the handler does nothing and normal startup flow creates the window.Generated with
mux