🤖 feat: add visual feedback when terminating background processes #1062
Conversation
- Show dimmed row + disabled X button immediately on click - Only clear terminating state on failure (to allow retry) - On success, subscription removes the process while still dimmed (no flash) _Generated with mux_
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Clear terminatingIds for processes no longer in the list (via subscription) - Clear all terminatingIds on workspace change - Fixes issue where restarting a process with same name would render dimmed
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…emoved Processes transition to killed/exited/failed before being removed from the list. Without this fix, a new process with the same name would render as terminating.
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
When clicking the terminate button on a background process, the X icon immediately swaps to a spinner and the row dims, giving instant visual feedback.
Changes
terminatingIdsinuseBackgroundBashHandlershookBackgroundProcessesBannerfor visual stylingLoader2icon instead of X while terminatingopacity-50+pointer-events-noneWhy only clear on failure?
Clearing on success causes a flash: the promise resolves slightly before the subscription arrives, briefly showing the X again. By only clearing on failure, the spinner stays until the subscription removes the row.
Generated with mux