Skip to content

Flake: TestWorkspaceProxyWorkspaceApps_BlockDirect/* #112

Closed
coder/coder
#22292

Description

@ethanndickson

TestWorkspaceProxyWorkspaceApps_BlockDirect/WorkspaceAppsProxySubdomain/WildcardPortOK
https://github.com/coder/coder/actions/runs/11379023829/job/31655767933

     t.go:108: 2024-10-17 05:41:35.305 [erro]  net.workspace-proxy.servertailnet: reinit multi agent  server_url=http://localhost:46203 ...
        error= failed to reach the Coordinate endpoint:
                   github.com/coder/coder/v2/enterprise/wsproxy/wsproxysdk.(*Client).DialCoordinator
                       /home/runner/work/coder/coder/enterprise/wsproxy/wsproxysdk/wsproxysdk.go:553
                 - session shutdown
         *** slogtest: log detected at level ERROR; TEST FAILURE ***

TestWorkspaceProxyWorkspaceApps_BlockDirect/WorkspaceAppsProxyPath/NoAccessShould404
https://github.com/coder/coder/actions/runs/11330954955/job/31509904359#step:5:956

 t.go:108: 2024-10-14 15:53:58.036 [erro]  net.workspace-proxy.servertailnet: reinit multi agent  server_url=http://localhost:36965 ...
        error= failed to reach the Coordinate endpoint:
                   github.com/coder/coder/v2/enterprise/wsproxy/wsproxysdk.(*Client).DialCoordinator
                       /home/runner/work/coder/coder/enterprise/wsproxy/wsproxysdk/wsproxysdk.go:553
                 - session shutdown
         *** slogtest: log detected at level ERROR; TEST FAILURE ***

Activity

  1. ethanndickson commented on Oct 17, 2024

    @ethanndickson
    MemberAuthor

    @sreya Assigning to you since it looks like the key rotation work changed workspace proxies a fair bit.

  2. added theissue type on Apr 10, 2025
  3. flake-investigator commented on Jan 8, 2026

    @flake-investigator

    New occurrence on main CI (linux, test-go-pg-17)

    CI run: https://github.com/coder/coder/actions/runs/20830288896
    Job: test-go-pg-17
    Commit: 1e8c292855d95612417ccda801a7dd1956dfcd84 (Yevhenii Shcherbina)

    Failing test:

    • enterprise/wsproxy TestWorkspaceProxyWorkspaceApps_BlockDirect/WorkspaceAppsProxyPath/RedirectsWithQuery

    Key evidence:

    [erro] failed to deregister workspace proxy with Coder primary (it will be automatically deregistered shortly)
      error= make request:
             github.com/coder/coder/v2/enterprise/wsproxy/wsproxysdk.(*Client).DeregisterWorkspaceProxy
               /home/runner/work/coder/coder/enterprise/wsproxy/wsproxysdk/wsproxysdk.go:250
           - Post "http://127.0.0.1:37077/api/v2/workspaceproxies/me/deregister": net/http: HTTP/1.x transport connection broken: http: CloseIdleConnections called
     *** slogtest: log detected at level ERROR; TEST FAILURE ***
    

    Notes:

    • This looks like shutdown ordering / teardown noise: deregister fails because the HTTP transport is already being torn down, but we log it at ERROR and slogtest fails the test.
    • Potential fix: downgrade this log to warn/debug, or suppress it when shutting down / when error is caused by CloseIdleConnections/context cancellation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions