This repository was archived by the owner on Nov 14, 2024. It is now read-only.
chore: refactor test helper function for HTTP API tests#8
Merged
Conversation
johnstcn
commented
Aug 25, 2021
| func (k *KubernetesChecker) CheckResources(ctx context.Context) []*api.CheckResult { | ||
| results := make([]*api.CheckResult, 0) | ||
| return results | ||
| } |
Member
Author
There was a problem hiding this comment.
This actually shouldn't be in here yet 😅
jawnsy
approved these changes
Aug 25, 2021
| err := json.NewEncoder(w).Encode(test.Response) | ||
| assert.Success(t, "failed to encode response", err) | ||
| })) | ||
| server := newTestHTTPServer(t, http.StatusOK, test.Response) |
There was a problem hiding this comment.
I was wondering whether we should override the client's RoundTripper instead of creating a test server, but 🤷♂️
seems good to me!
Member
Author
There was a problem hiding this comment.
Yeah, you can do some fun stuff with that. I especially like the look of NewFileTransport (https://pkg.go.dev/net/http#NewFileTransport).
If (when?) we end up needing to do lots of complex request/response interactions in unit tests, it might be worthwhile looking into this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bit of repeated code in the unit tests that can be refactored into a helper function.