Skip to content
This repository was archived by the owner on Nov 14, 2024. It is now read-only.

chore: add build infrastructure and linting#2

Merged
jawnsy merged 1 commit intomainfrom
jawnsy/ch15960/build-formatting
Aug 12, 2021
Merged

chore: add build infrastructure and linting#2
jawnsy merged 1 commit intomainfrom
jawnsy/ch15960/build-formatting

Conversation

@jawnsy
Copy link
Copy Markdown

@jawnsy jawnsy commented Aug 7, 2021

No description provided.

@jawnsy jawnsy self-assigned this Aug 7, 2021
@shortcut-integration
Copy link
Copy Markdown

This pull request has been linked to Clubhouse Story #15960: Add build and formatting settings.

@jawnsy jawnsy marked this pull request as draft August 7, 2021 16:48
@jawnsy jawnsy marked this pull request as ready for review August 12, 2021 01:41
@jawnsy jawnsy merged commit f4ddbf6 into main Aug 12, 2021
@jawnsy jawnsy deleted the jawnsy/ch15960/build-formatting branch August 12, 2021 04:37
# Over time, add more and more linters from
# https://golangci-lint.run/usage/linters/ as the code improves.
linters:
disable-all: true
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is greenfield, why not enable all linters?

two prior minor releases and current release. For details, see
https://www.notion.so/Kubernetes-version-support-strategy-82ecd5c9761e411e9dab61a7a1484418
local_replace_directives: true
importas:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neat!

Copy link
Copy Markdown
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants