chore: check error from CompactRules (#23)

Jonathan Yu · web-flow · commit 3c80a35bed33 · 2021-09-19T09:54:49.000-07:00
The function currently never returns errors, but this is not
guaranteed to remain the case in the future, nor by the API
contract, so it's safer to check.
diff --git a/internal/checks/kube/rbac.go b/internal/checks/kube/rbac.go
@@ -70,7 +70,11 @@ func (k *KubernetesChecker) checkRBACDefault(ctx context.Context) ([]*api.CheckR
 		breakdownRules = append(breakdownRules, rbacutil.BreakdownRule(rule)...)
 	}
 
-	compactRules, _ := rbacutil.CompactRules(breakdownRules) //nolint:errcheck - err is always nil
+	compactRules, err := rbacutil.CompactRules(breakdownRules)
+	if err != nil {
+		return nil, xerrors.Errorf("compact rules: %w", err)
+	}
+
 	sort.Stable(rbacutil.SortableRuleSlice(compactRules))
 	for _, r := range compactRules {
 		k.log.Debug(ctx, "Got SSRR PolicyRule", slog.F("rule", r))
