Skip to content

chore: add a test commit (don't merge) - #892

Closed
jsjoeio wants to merge 2 commits into
coder:mainfrom
jsjoeio:test-joe
Closed

jsjoeio wants to merge 2 commits into
coder:mainfrom
jsjoeio:test-joe

Conversation

@jsjoeio

@jsjoeio jsjoeio commented Apr 6, 2022

Copy link
Copy Markdown
Contributor

This is a test from a forked repo of coder to ensure that CI checks run as expected.

#653

@jsjoeio jsjoeio self-assigned this Apr 6, 2022
@jsjoeio
jsjoeio requested review from a team April 6, 2022 18:16

@deansheather deansheather left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is amazing! merge this immediately!!!! 🚀

@code-asher code-asher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looking forward to Joe managing all my tunnels

@jsjoeio

jsjoeio commented Apr 6, 2022

Copy link
Copy Markdown
Contributor Author

cc @kylecarbs or anyone else: CI jobs still haven't run. Is that expected?

@kylecarbs

Copy link
Copy Markdown
Member

Merge in main and they will!

@jsjoeio

jsjoeio commented Apr 6, 2022

Copy link
Copy Markdown
Contributor Author

Merge in main and they will!

Hmm...is that the desired behavior we want? I wouldn't think so because then we'd have to merge community code before knowing if it passes all our checks.

@jsjoeio

jsjoeio commented Apr 7, 2022

Copy link
Copy Markdown
Contributor Author

Merge in main and they will!

I may have misunderstood this. I am guessing you meant "merge in main" as in "update your branch with main".

Let's see if it works!

@jsjoeio

jsjoeio commented Apr 12, 2022

Copy link
Copy Markdown
Contributor Author

Discussed with @kylecarbs - we're not sure why CI isn't running. We're going to revisit this once we flip the switch and make this public.

@jsjoeio jsjoeio closed this Apr 12, 2022
@jsjoeio
jsjoeio deleted the test-joe branch April 12, 2022 19:51
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
mafredri added a commit that referenced this pull request Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants