Repository navigation
Conversation
Codecov Report
@@ Coverage Diff @@
## main #880 +/- ##
==========================================
+ Coverage 65.52% 65.75% +0.22%
==========================================
Files 216 216
Lines 13733 13733
Branches 103 103
==========================================
+ Hits 8999 9030 +31
+ Misses 3807 3780 -27
+ Partials 927 923 -4
Continue to review full report at Codecov.
|
Member
Author
|
I somehow net positive one line. Sucks to suck I guess. |
presleyp
approved these changes
Apr 5, 2022
Customer feedback indicated projects was a confusing name. After querying the team internally, it seemed unanimous that it is indeed a confusing name. Here's for a lil less confusion @ashmeer7 🥂
f0ssel
approved these changes
Apr 5, 2022
greyscaled
approved these changes
Apr 6, 2022
johnstcn
reviewed
Apr 6, 2022
| // Compare checks the equality of passwords from a hashed pbkdf2 string. | ||
| // This uses pbkdf2 to ensure FIPS 140-2 compliance. See: | ||
| // https://csrc.nist.gov/csrc/media/projects/cryptographic-module-validation-program/documents/security-policies/140sp2261.pdf | ||
| // https://csrc.nist.gov/csrc/media/templates/cryptographic-module-validation-program/documents/security-policies/140sp2261.pdf |
johnstcn
reviewed
Apr 6, 2022
johnstcn
reviewed
Apr 6, 2022
johnstcn
approved these changes
Apr 6, 2022
johnstcn
left a comment
johnstcn
left a comment
Member
There was a problem hiding this comment.
LGTM, just one broken URL in a comment (easy fix)
|
This was the fastest I've ever complained about something to it being in code 👍 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer feedback indicated "projects" is a confusing name.
After querying the team internally, it seemed unanimous
that it is indeed a confusing name.
Here's to a lil less confusion @ashmeer7 🥂