Skip to content

fix(site): Prompting user for missing variables #7002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BrunoQuaresma merged 3 commits into from
Apr 4, 2023
Merged

fix(site): Prompting user for missing variables #7002

BrunoQuaresma merged 3 commits into from
Apr 4, 2023

Conversation

@BrunoQuaresma
Copy link
Contributor

@BrunoQuaresma BrunoQuaresma commented Apr 4, 2023

Fix #6941

BrunoQuaresma
BrunoQuaresma commented Apr 4, 2023
View reviewed changes
site/src/api/api.ts
requiredParameters.push(p)
return
}
})
Copy link
Contributor Author

@BrunoQuaresma BrunoQuaresma Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtojek @bpmct is this logic correct? I must admit that asking or not for missing parameters is pretty challenging to understand for me 😅

Copy link
Member

@mtojek mtojek Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try it locally...

@BrunoQuaresma BrunoQuaresma requested review from bpmct and mtojek April 4, 2023 12:31
@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) April 4, 2023 13:06
@BrunoQuaresma BrunoQuaresma merged commit 46f42ea into main Apr 4, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-immutable-parameters branch April 4, 2023 13:15
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mtojek mtojek mtojek approved these changes

@bpmct bpmct Awaiting requested review from bpmct

Assignees

@BrunoQuaresma BrunoQuaresma

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rich parameters: not prompting me for missing variables

3 participants

@BrunoQuaresma @mtojek