Repository navigation
feat: add startup script logs to the ui - #6558
Merged
Merged
Conversation
sreya
reviewed
Mar 15, 2023
Comment on lines
+690
to
+693
| if flushLogsTimer != nil { | ||
| flushLogsTimer.Reset(100 * time.Millisecond) | ||
| return | ||
| } |
Collaborator
There was a problem hiding this comment.
why do we reset the timer here?
Member
Author
There was a problem hiding this comment.
debounce baby. i'll add a comment
sreya
approved these changes
Mar 17, 2023
kylecarbs
marked this pull request as ready for review
March 18, 2023 17:38
kylecarbs
force-pushed
the
startuplogs
branch
2 times, most recently
from
March 23, 2023 04:37
a559240 to
144fd17
Compare
kylecarbs
enabled auto-merge (squash)
March 23, 2023 04:47
kylecarbs
disabled auto-merge
March 23, 2023 04:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Courtesy of @code-asher
Todo