Repository navigation
fix(coderd): Detect agent disconnect via inactivity - #6528
Merged
Merged
Conversation
mafredri
force-pushed
the
mafredri/fix-agent-disconnect-detection
branch
from
March 9, 2023 14:57
d35f8ff to
50be1ca
Compare
mafredri
force-pushed
the
mafredri/fix-agent-disconnect-detection
branch
from
March 9, 2023 14:58
50be1ca to
dc70eab
Compare
johnstcn
approved these changes
Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The increased Ping interval is not ideal, but this is a fairly simple proposal for detecting inactive agents which can happen when the network becomes unreachable.
Fixes #5901