Repository navigation
fix(agent): Allow signal propagation when running as PID 1 - #6141
Merged
Merged
Conversation
mafredri
changed the title
mtojek
reviewed
Feb 10, 2023
mtojek
left a comment
mtojek
left a comment
Member
There was a problem hiding this comment.
Post-merge review, LGTM :+1
I admit that this had also an educational value for me, thanks for the ping!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the agent was running as PID 1 and performing it's reaping duties, Docker ended up killing it immediately on stop instead of gracefully as one would hope. This adds some signal propagation so that interrupts are sent to the forked agent.