Repository navigation
feat(agent): Add shutdown lifecycle states and shutdown_script support - #6139
Merged
Merged
Conversation
This was referenced Feb 10, 2023
mafredri
force-pushed
the
mafredri/feat-shutdown-script
branch
from
February 13, 2023 13:05
49f04ad to
a1222d0
Compare
Member
Author
This was referenced Feb 13, 2023
mafredri
marked this pull request as ready for review
February 13, 2023 18:15
mtojek
approved these changes
Feb 14, 2023
mtojek
left a comment
Member
There was a problem hiding this comment.
Nice!
LGTM, but I didn't analyze it too deeply as the PR is massive.
mafredri
force-pushed
the
mafredri/feat-shutdown-script
branch
from
February 20, 2023 13:35
2ac1a38 to
2ca1810
Compare
kylecarbs
removed their request for review
February 26, 2023 18:05
Contributor
|
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
Member
|
Hey @mafredri! Is it something that you will continue to work soon? |
Member
Author
Yup, I'll get this rebased and (try to) merge it today. 👍🏻 |
mafredri
force-pushed
the
mafredri/feat-shutdown-script
branch
from
March 6, 2023 12:04
2ca1810 to
22ad8b9
Compare
shutdown_script support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for agent shutdown lifecycle states and
shutdown_script.It (currently) relies on terraform provider abilities to gracefully shut down. For instance with the docker provider it can be controlled via:
The agent can handle common signals like
SIGHUP,SIGINT,SIGTERM. If need be, more signals could be handled.Builds upon #5171
Fixes #4677
Note:
stopping,stop_timeout,stop_error,stopped, yay or nay to make this change?