chore: Drop unused Experimental flag from api options #5715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hmm, why add this if it's unused? Feels odd. |
Member
Author
|
Good point. We return the entitlements in the enterprise route for the UI to consume. I just noticed this when trying to implement a backend experimental feature. I'll just drop it for now. |
Emyrk
changed the title
Member
|
Would it instead make more sense to refactor the |
Member
Author
|
@johnstcn It would be nice to support that kind of behavior. This PR just drops the unused flag so no one tries to use it and realizes it does nothing. A future PR can re-add this functionality in a way that works. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
experimentalflag is only set on Enterprise routes viaupdateEntitlements.In the free version,
Experimentalis on the api config and never set.Dropping the unused boolean.