Repository navigation
fix(coderd): clean up task snapshots on task deletion - #21949
Merged
Merged
Conversation
Task snapshots were orphaned when tasks were soft-deleted. The `task_snapshots` table has an `ON DELETE CASCADE` foreign key, but that only fires on hard deletes. Modified DeleteTask to use a CTE that atomically soft-deletes the task and removes its snapshot in a single transaction. The query now returns just the task UUID instead of the full row. Closes coder/internal#1283
mafredri
force-pushed
the
mafredri/feat-tasks-cleanup-snapshots
branch
from
February 6, 2026 09:24
92c6f7d to
5b6dcce
Compare
mafredri
marked this pull request as ready for review
February 6, 2026 09:44
johnstcn
approved these changes
Feb 6, 2026
Comment on lines
+68
to
+71
| ), deleted_snapshot AS ( | ||
| DELETE FROM task_snapshots | ||
| WHERE task_id = @id::uuid | ||
| ) |
DanielleMaywood
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task snapshots were orphaned when tasks were soft-deleted. The
task_snapshotstable has anON DELETE CASCADEforeign key, butthat only fires on hard deletes.
Modified DeleteTask to use a CTE that atomically soft-deletes the
task and removes its snapshot in a single transaction. The query now
returns just the task UUID instead of the full row.
Closes coder/internal#1283