chore(coderd/database/dbfake): add support for provisioner job timestamp control - #21944

Add a Failed() method to WorkspaceBuildBuilder that sets the provisioner
job to a failed state with the given error message and error code. This
allows tests to create failed workspace builds using the builder pattern
instead of manually creating provisioner jobs with dbgen.

Migrate coderd/notifications/reports/generator_internal_test.go to use
the new dbfake.WorkspaceBuild builder with:
- Failed() method for failed builds
- WithJobCompletedAt() method for timestamp control

This simplifies test setup by consolidating workspace build and
provisioner job creation into a single fluent builder call.

Migrate TestTemplateUpdateBuildDeadlines to use the new
WorkspaceBuildBuilder timestamp control methods instead of manual
AcquireProvisionerJob + UpdateProvisionerJobWithCompleteByID calls.

This simplifies test setup by using:
- dbfake.WorkspaceBuild() to create workspace, job, and build together
- .WithJobCompletedAt(buildTime) to set the job completion timestamp
- .Seed() to pass custom build parameters like ProvisionerState

The second test (TestTemplateUpdateBuildDeadlinesSkip) was not migrated
because it requires failed build states which the builder doesn't
currently support.

…p control

Replace custom withCreatedAt helper pattern with the standard
dbfake.WorkspaceBuildBuilder.WithJobCreatedAt() method in
TestExpiredPrebuildsMultipleActions.

Changes:
- Replace setupTestDBPrebuild call with dbfake.WorkspaceBuild() when
  timestamp control is needed for expiration testing
- Remove prebuildOptions struct, prebuildOption type, and withCreatedAt
  helper function (no longer needed)
- Remove opts parameter from setupTestDBPrebuild and setupTestDBWorkspace
  functions

This standardizes timestamp control in tests to use the new builder
methods available in dbfake.WorkspaceBuildBuilder.

… timestamp methods

This commit migrates the workspace runtime audit tests to use the
WorkspaceBuildBuilder's new timestamp control methods instead of manually
creating provisioner jobs with explicit timestamps.

Changes:
- Add Failed() method to WorkspaceBuildBuilder for failed job status
- Add ProvisionerJobStatusFailed case handling in builder's switch
- Refactor createWorkspace() to use dbfake.WorkspaceBuild with
  WithJobCreatedAt/WithJobCompletedAt methods
- Remove redundant 'canceled' field from workspaceBuildArgs struct
- Remove unused 'database/sql' import

The new approach simplifies test setup while preserving existing behavior.
All tests continue to pass.

…spaceBuildBuilder

Migrate the following tests to use the new dbfake.WorkspaceBuildBuilder
timestamp control methods instead of manual dbgen.ProvisionerJob setup:

- TestDetectorHungWorkspaceBuild
- TestDetectorHungWorkspaceBuildNoOverrideState
- TestDetectorHungWorkspaceBuildNoOverrideStateIfNoExistingBuild
- TestDetectorPendingWorkspaceBuildNoOverrideStateIfNoExistingBuild
- TestDetectorWorkspaceBuildForDormantWorkspace

This significantly reduces boilerplate while making the test setup clearer.
The builder handles all the necessary relationships automatically.

This method allows setting the UpdatedAt field separately from StartedAt
when creating running jobs. This is essential for testing hung job
detection where the detector checks UpdatedAt to determine if a job
has been idle for too long.

The AcquireProvisionerJob query sets UpdatedAt = StartedAt, so this
method updates UpdatedAt after job acquisition to enable the necessary
test scenario.

Address review feedback on WorkspaceBuildBuilder migration:

1. Use correct timestamps for hung job tests: the original tests had
   CreatedAt=tenMinAgo, StartedAt=tenMinAgo, UpdatedAt=sixMinAgo.
   The hung job detector checks UpdatedAt to determine if a job is
   hung, so these values must match the original test behavior.

2. Set DormantAt directly in workspace seed instead of using post-hoc
   UpdateWorkspaceDormantDeletingAt call. This simplifies the test
   and eliminates the need to refetch the workspace.

Remove ineffassign warning by eliminating unused workspace assignment
and using buildResp.Build directly instead of creating an alias.

Address review feedback on the WorkspaceBuildBuilder timestamp migration:

1. Remove unnecessary comment in runtimeaudit_test.go (line 383)

2. Remove unnecessary comment in reconcile_test.go (lines 1833-1834)

3. Remove unnecessary alias in reconcile_test.go (line 1850)
   Use `resp.Workspace` directly instead of aliasing to `workspace`.

4. Simplify API by accepting variadic time.Time in status methods:
   - Starting(ts ...time.Time): timestamp used for StartedAt
   - Pending(ts ...time.Time): timestamp used for CreatedAt
   - Canceled(ts ...time.Time): timestamp used for CompletedAt
   - Failed(jobError, jobErrorCode string, ts ...time.Time): timestamp used for CompletedAt

5. Remove WithJobCreatedAt and WithJobStartedAt methods

6. Keep WithJobUpdatedAt for hung job tests where UpdatedAt != StartedAt

7. Keep WithJobCompletedAt for succeeded builds that need completion timestamps

8. Job CreatedAt now defaults to workspace CreatedAt when not explicitly set,
   which allows expiration tests to work without needing WithJobCreatedAt.

All callers updated to use the simplified API:
- Starting().WithJobStartedAt(t) → Starting(t)
- Pending().WithJobCreatedAt(t) → Pending(t)
- Canceled().WithJobCompletedAt(t) → Canceled(t)
- Failed(...).WithJobCompletedAt(t) → Failed(..., t)

…ary comments

- Rename WithJobUpdatedAt to JobUpdatedAt
- Rename WithJobCompletedAt to JobCompletedAt
- Remove unnecessary comments in doInTX()

- Add Succeeded(ts ...time.Time) for consistency with other status methods
- Remove JobCompletedAt() as Succeeded() now handles this case
- Fix Canceled() comment to mention both CanceledAt and CompletedAt

Update the 4 remaining callers of the removed UpdateJob method to use
the new functional options pattern (WithJobCompletedAt). Also removes
unused 'database/sql' import from runtimeaudit_test.go.

Add WithJobError and WithJobErrorCode BuilderOption functions and change
Failed() to only accept ...BuilderOption instead of explicit jobError and
jobErrorCode string parameters. This makes the API more consistent with
other builder methods where all customization is done via options.

The default error message 'failed' is still used when no WithJobError
option is provided.