Repository navigation
fix(coderd/database): correct task pending status logic - #21886
Merged
Merged
Conversation
mafredri
force-pushed
the
mafredri/fix-task-pending-status
branch
3 times, most recently
from
February 5, 2026 11:40
33bfeae to
59b3504
Compare
Previously, tasks with pending provisioner jobs (not yet picked up) were incorrectly reported as "initializing". Refs coder/internal#1265
mafredri
force-pushed
the
mafredri/fix-task-pending-status
branch
from
February 5, 2026 11:50
59b3504 to
cd03cca
Compare
mafredri
marked this pull request as ready for review
February 5, 2026 11:50
DanielleMaywood
approved these changes
Feb 5, 2026
johnstcn
approved these changes
Feb 5, 2026
| WHEN (latest_build_raw.job_status = ANY (ARRAY['failed'::provisioner_job_status, 'canceling'::provisioner_job_status, 'canceled'::provisioner_job_status])) THEN 'error'::task_status | ||
| WHEN ((latest_build_raw.transition = ANY (ARRAY['stop'::workspace_transition, 'delete'::workspace_transition])) AND (latest_build_raw.job_status = 'succeeded'::provisioner_job_status)) THEN 'paused'::task_status | ||
| WHEN ((latest_build_raw.transition = 'start'::workspace_transition) AND (latest_build_raw.job_status = 'pending'::provisioner_job_status)) THEN 'initializing'::task_status | ||
| WHEN ((latest_build_raw.transition = 'start'::workspace_transition) AND (latest_build_raw.job_status = 'pending'::provisioner_job_status)) THEN 'pending'::task_status |
Member
There was a problem hiding this comment.
One of the few times when looking at the diff of this file is useful :D
Member
There was a problem hiding this comment.
Obligatory reminder to check migration number before clicking the big green button!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, tasks with pending provisioner jobs (not yet picked up)
were incorrectly reported as "initializing".
Refs #21887