Skip to content

feat: show sharing info at bottom of AppLink's tooltip - #21197

Merged
aqandrew merged 5 commits into
mainfrom
aqandrew/replace-mui-tooltip-shareicon
Dec 11, 2025
Merged

aqandrew merged 5 commits into
mainfrom
aqandrew/replace-mui-tooltip-shareicon

Conversation

@aqandrew

@aqandrew aqandrew commented Dec 9, 2025 •

Copy link
Copy Markdown
Contributor

for #19974

ShareIcon, which returns a MUI tooltip, had these problems:

  1. There was no Storybook story which rendered the "Open external URL" tooltip
  2. AppLink renders a button. If it has tooltip text, this button is also a Radix TooltipTrigger. Since ShareIcon is rendered as a child of the AppLink button, ShareIcon's tooltip (a nested tooltip) was never appearing. I did try turning ShareIcon into a Radix tooltip as well, but I still couldn't get the nested tooltip's text to appear, and nested tooltips are not very accessible. AFAIK there's no way to focus a child element of a button.

I've deleted the separate ShareIcon component and moved ShareIcon's tooltip text to the bottom of AppLink's tooltip:

before

image

^The UsersIcon on the right is a MUI tooltip trigger, but it can't receive focus. It's supposed to show the text "Shared with all authenticated users" when focused

after

image

@aqandrew aqandrew changed the title refactor: move ShareIcon logic to AppLink feat: show AppLink's sharing info at bottom of tooltip Dec 9, 2025
@aqandrew aqandrew changed the title feat: show AppLink's sharing info at bottom of tooltip feat: show sharing info at bottom of AppLink's tooltip Dec 9, 2025
@aqandrew
aqandrew requested review from aslilac and jaaydenh December 9, 2025 23:35
@aqandrew
aqandrew merged commit a87a444 into main Dec 11, 2025
30 checks passed
@aqandrew
aqandrew deleted the aqandrew/replace-mui-tooltip-shareicon branch December 11, 2025 21:30
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants