Repository navigation
feat: show sharing info at bottom of AppLink's tooltip - #21197
Merged
Merged
Conversation
aslilac
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #19974
ShareIcon, which returns a MUI tooltip, had these problems:AppLinkrenders a button. If it has tooltip text, this button is also a RadixTooltipTrigger. SinceShareIconis rendered as a child of theAppLinkbutton,ShareIcon's tooltip (a nested tooltip) was never appearing. I did try turningShareIconinto a Radix tooltip as well, but I still couldn't get the nested tooltip's text to appear, and nested tooltips are not very accessible. AFAIK there's no way to focus a child element of a button.I've deleted the separate
ShareIconcomponent and movedShareIcon's tooltip text to the bottom ofAppLink's tooltip:before
^The
UsersIconon the right is a MUI tooltip trigger, but it can't receive focus. It's supposed to show the text "Shared with all authenticated users" when focusedafter