Repository navigation
fix: show task display name in task topbar - #20957
Merged
Merged
Conversation
ssncferreira
commented
Nov 26, 2025
| </TooltipProvider> | ||
|
|
||
| <h1 className="m-0 pl-2 text-base font-medium truncate">{task.name}</h1> | ||
| <h1 className="m-0 pl-2 text-base font-medium max-w-[520px] truncate"> |
Contributor
Author
There was a problem hiding this comment.
Just defaulting to the same value as in the Tasks list view. In the backend, we also always guarantee that the display name is only 64 characters, which should not reach this maximum.
ssncferreira
marked this pull request as ready for review
November 26, 2025 19:56
Contributor
Contributor
Author
Nice catch 👀 Addressed in: 2b64a2e with some styling changes, but not sure if it is the best way |
| </TooltipProvider> | ||
|
|
||
| <h1 className="m-0 pl-2 text-base font-medium truncate">{task.name}</h1> | ||
| <h1 className="m-0 pl-2 text-base font-medium max-w-[520px] truncate"> |
Contributor
There was a problem hiding this comment.
Suggested change
| <h1 className="m-0 pl-2 text-base font-medium max-w-[520px] truncate"> | |
| <h1 className="m-0 pl-2 text-base font-medium max-w-[64ch] truncate"> |
We talked about this during our chat, unsure if we do this pattern elsewhere but it might look less magic to someone reading in the future
Contributor
Author
There was a problem hiding this comment.
As discussed on Slack, it looks like this doesn’t exactly meet the 64-characters, which leads to the page width expanding, which isn’t ideal 🙁
DanielleMaywood
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Update task topbar in task page to show display name, instead of task name.
Follow-up PR: #20918
Related to internal slack thread: https://codercom.slack.com/archives/C0992H8HGCS/p1764086497375829